Add support for mapping ConstraintViolation objects into SimpleBeanEditor.

Add support for mapping ConstraintViolation objects into SimpleBeanEditor.
Patch by: bobv
Review by: rjrjr

[rjrjr]

Nick, could you take a look at this? Is Bob making reasonable assumptions about
how ConstraintViolation acts, especially its paths?

[rjrjr]

http://gwt-code-reviews.appspot.com/1260801/diff/1/3
File user/src/com/google/gwt/editor/client/SimpleBeanEditorDriver.java (right):

http://gwt-code-reviews.appspot.com/1260801/diff/1/3#newcode25
user/src/com/google/gwt/editor/client/SimpleBeanEditorDriver.java:25: * {@link
EditorDelegate#subscribe()}.
Add a note that this interface is implemented by generated code, and that
incompatible changes may be made from time to time? I should do the same to
UiBinder

http://gwt-code-reviews.appspot.com/1260801/diff/1/3#newcode85
user/src/com/google/gwt/editor/client/SimpleBeanEditorDriver.java:85: * JSR 303
Validator. The violations will be converted into
Let's try to get away from the JSR verbiage. Just "probably generated by a
{@link javax.validation.Validator}."

http://gwt-code-reviews.appspot.com/1260801/diff/1/5
File user/src/com/google/gwt/editor/client/impl/EditorDriverUtils.java (right):

http://gwt-code-reviews.appspot.com/1260801/diff/1/5#newcode26
user/src/com/google/gwt/editor/client/impl/EditorDriverUtils.java:26: public
class EditorDriverUtils {
How about changing this to abstract class SimpleViolation, rather than using the
nested interface?  Util classes always give me a misc-rash.

http://gwt-code-reviews.appspot.com/1260801/diff/1/5#newcode32
user/src/com/google/gwt/editor/client/impl/EditorDriverUtils.java:32: public
static class ConstraintViolationIterable implements
And this doesn't need to be a public type. Could have a static method
SimpleViolation#iterableFromConstraintViolations(Iterable<ConstraintViolation<?>>)

[Nick Chalko]

Will do.

On Thu, Jan 6, 2011 at 9:31 AM, <rjrjr@google.com> wrote:

> Nick, could you take a look at this? Is Bob making reasonable
> assumptions about how ConstraintViolation acts, especially its paths?
>
>
> http://gwt-code-reviews.appspot.com/1260801/show
>



-- 
Generate your java flags for easier testing.
go/java_flags <https://goto.google.com/java_flags>
 <https://goto.google.com/java_flags>

[Nick Chalko]

I am just now starting to really deal with the Path in client side code, so my
answers are incomplete.  

IIRC the toString for the path is not part of the spec, so it may not be safe to
rely on it.  Leave a TODO to verify that.

Are you sure you need the SimpleViolation?  Not sure what it is gaining us here.

http://gwt-code-reviews.appspot.com/1260801/diff/1/9
File
user/src/com/google/gwt/requestfactory/client/testing/MockRequestFactoryEditorDriver.java
(right):

http://gwt-code-reviews.appspot.com/1260801/diff/1/9#newcode149
user/src/com/google/gwt/requestfactory/client/testing/MockRequestFactoryEditorDriver.java:149:
// TODO Auto-generated method stub
Remove TODO

[bobv]

Patch updated.

The whole SimpleViolation class exists to accomodate the interim "Violation"
interface provided by RequestFactory, since ConstraintViolation in the client
was in flux when we were designing the RF API.  The Violation API needs to be
deprecated and eliminated in the future.  Once that's done, SimpleViolation can
also go away.

http://gwt-code-reviews.appspot.com/1260801/diff/1/3
File user/src/com/google/gwt/editor/client/SimpleBeanEditorDriver.java (right):

http://gwt-code-reviews.appspot.com/1260801/diff/1/3#newcode25
user/src/com/google/gwt/editor/client/SimpleBeanEditorDriver.java:25: * {@link
EditorDelegate#subscribe()}.
On 2011/01/06 17:57:10, rjrjr wrote:
> Add a note that this interface is implemented by generated code, and that
> incompatible changes may be made from time to time? I should do the same to
> UiBinder
> 

Done.

http://gwt-code-reviews.appspot.com/1260801/diff/1/3#newcode85
user/src/com/google/gwt/editor/client/SimpleBeanEditorDriver.java:85: * JSR 303
Validator. The violations will be converted into
On 2011/01/06 17:57:10, rjrjr wrote:
> Let's try to get away from the JSR verbiage. Just "probably generated by a
> {@link javax.validation.Validator}."

Done.

http://gwt-code-reviews.appspot.com/1260801/diff/1/5
File user/src/com/google/gwt/editor/client/impl/EditorDriverUtils.java (right):

http://gwt-code-reviews.appspot.com/1260801/diff/1/5#newcode26
user/src/com/google/gwt/editor/client/impl/EditorDriverUtils.java:26: public
class EditorDriverUtils {
On 2011/01/06 17:57:10, rjrjr wrote:
> How about changing this to abstract class SimpleViolation, rather than using
the
> nested interface?  Util classes always give me a misc-rash.

Done.

http://gwt-code-reviews.appspot.com/1260801/diff/1/5#newcode32
user/src/com/google/gwt/editor/client/impl/EditorDriverUtils.java:32: public
static class ConstraintViolationIterable implements
On 2011/01/06 17:57:10, rjrjr wrote:
> And this doesn't need to be a public type. Could have a static method
>
SimpleViolation#iterableFromConstraintViolations(Iterable<ConstraintViolation<?>>)

Done.

http://gwt-code-reviews.appspot.com/1260801/diff/1/9
File
user/src/com/google/gwt/requestfactory/client/testing/MockRequestFactoryEditorDriver.java
(right):

http://gwt-code-reviews.appspot.com/1260801/diff/1/9#newcode149
user/src/com/google/gwt/requestfactory/client/testing/MockRequestFactoryEditorDriver.java:149:
// TODO Auto-generated method stub
On 2011/01/06 22:31:02, Nick Chalko wrote:
> Remove TODO

Done.

[Nick Chalko]

LGTM

[bobv]

Updated this patch with a hack to ApiChecker that allows it to find the external
javax.validation source jars.

[Nick Chalko]

lgtm

[rjrjr]

Bob, did this land?

On Mon, Jan 10, 2011 at 2:45 PM, <nchalko@google.com> wrote:

> LGTM
>
>
> http://gwt-code-reviews.appspot.com/1260801/show
>

[bobv]

On Thu, Jan 20, 2011 at 10:00 PM, Ray Ryan <rjrjr@google.com> wrote:
> Bob, did this land?

r9562


-- 
Bob Vawter
Google Web Toolkit Team