Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(71)

Issue 1260801: Add support for mapping ConstraintViolation objects into SimpleBeanEditor. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by bobv
Modified:
6 years, 1 month ago
Reviewers:
rjrjr, Nick Chalko
CC:
google-web-toolkit-contributors_googlegroups.com
Base URL:
http://google-web-toolkit.googlecode.com/svn/
Visibility:
Public.

Description

Add support for mapping ConstraintViolation objects into SimpleBeanEditor.
Patch by: bobv
Review by: rjrjr

Patch Set 1

Total comments: 10

Patch Set 2 : Feedback

Patch Set 3 : Hacky fix for ApiChecker

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M build.xml View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/api-checker/src/com/google/gwt/tools/apichecker/ApiCompatibilityChecker.java View 10 chunks +128 lines, -75 lines 0 comments Download
M user/src/com/google/gwt/editor/Editor.gwt.xml View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M user/src/com/google/gwt/editor/client/SimpleBeanEditorDriver.java View 1 2 3 chunks +18 lines, -0 lines 0 comments Download
M user/src/com/google/gwt/editor/client/impl/AbstractSimpleBeanEditorDriver.java View 1 2 2 chunks +15 lines, -0 lines 0 comments Download
A user/src/com/google/gwt/editor/client/impl/SimpleViolation.java View 1 chunk +162 lines, -0 lines 0 comments Download
M user/src/com/google/gwt/editor/client/testing/MockSimpleBeanEditorDriver.java View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M user/src/com/google/gwt/requestfactory/client/RequestFactoryEditorDriver.java View 1 2 7 chunks +29 lines, -14 lines 0 comments Download
M user/src/com/google/gwt/requestfactory/client/impl/AbstractRequestFactoryEditorDriver.java View 1 2 5 chunks +80 lines, -45 lines 0 comments Download
M user/src/com/google/gwt/requestfactory/client/testing/MockRequestFactoryEditorDriver.java View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M user/test/com/google/gwt/editor/rebind/model/EditorModelTest.java View 2 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 10
rjrjr
Nick, could you take a look at this? Is Bob making reasonable assumptions about how ...
6 years, 2 months ago #1
rjrjr
http://gwt-code-reviews.appspot.com/1260801/diff/1/3 File user/src/com/google/gwt/editor/client/SimpleBeanEditorDriver.java (right): http://gwt-code-reviews.appspot.com/1260801/diff/1/3#newcode25 user/src/com/google/gwt/editor/client/SimpleBeanEditorDriver.java:25: * {@link EditorDelegate#subscribe()}. Add a note that this interface ...
6 years, 2 months ago #2
Nick Chalko
Will do. On Thu, Jan 6, 2011 at 9:31 AM, <rjrjr@google.com> wrote: > Nick, could ...
6 years, 2 months ago #3
Nick Chalko
I am just now starting to really deal with the Path in client side code, ...
6 years, 2 months ago #4
bobv
Patch updated. The whole SimpleViolation class exists to accomodate the interim "Violation" interface provided by ...
6 years, 2 months ago #5
Nick Chalko
LGTM
6 years, 2 months ago #6
bobv
Updated this patch with a hack to ApiChecker that allows it to find the external ...
6 years, 2 months ago #7
Nick Chalko
lgtm
6 years, 2 months ago #8
rjrjr
Bob, did this land? On Mon, Jan 10, 2011 at 2:45 PM, <nchalko@google.com> wrote: > ...
6 years, 2 months ago #9
bobv
6 years, 2 months ago #10
On Thu, Jan 20, 2011 at 10:00 PM, Ray Ryan <rjrjr@google.com> wrote:
> Bob, did this land?

r9562


-- 
Bob Vawter
Google Web Toolkit Team
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld revision f51cb906c4ad+