Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(52)

Issue 1357803: CompositeEditor and subclasses now takes Editor<? super T> instead of Editor<T> (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by tbroyer
Modified:
3 years, 8 months ago
Reviewers:
rdayal
CC:
google-web-toolkit-contributors_googlegroups.com
Base URL:
Visibility:
Public.

Description

In the first patch set, ListEditor is also made a CompositeEditor<List<? extends
T>, T, E>. This is however a breaking change (see SimpleBeanEditorTest).

The second patch set only changes CompositeEditor (and subclasses) to use
Editor<? super T> instead of Editor<T> (which also put it on par with the editor
driver).

Patch Set 1

Patch Set 2 : CompositeEditor and subclasses now takes Editor<? super T> instead of Editor<T>

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M user/src/com/google/gwt/editor/client/CompositeEditor.java View 2 chunks +2 lines, -2 lines 0 comments Download
M user/src/com/google/gwt/editor/client/adapters/ListEditor.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
M user/src/com/google/gwt/editor/client/adapters/ListEditorWrapper.java View 1 chunk +1 line, -1 line 0 comments Download
M user/src/com/google/gwt/editor/client/adapters/OptionalFieldEditor.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
tbroyer
Not sure if it was on your radar Bob, so I'm adding you as a ...
6 years, 1 month ago #1
tbroyer
Filed on issue tracker: http://code.google.com/p/google-web-toolkit/issues/detail?id=6139
6 years ago #2
tbroyer
3 years, 8 months ago #3
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld revision f51cb906c4ad+