Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(272)

Issue 1383809: ie9 bug fixes.

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by fabiomfv
Modified:
4 years, 1 month ago
CC:
google-web-toolkit-contributors_googlegroups.com
Base URL:
http://google-web-toolkit.googlecode.com/svn/
Visibility:
Public.

Description

ie9 bug fixes.

Patch Set 1

Total comments: 1

Patch Set 2 : update

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M user/src/com/google/gwt/dom/client/DOMImpl.java View 1 1 chunk +7 lines, -0 lines 0 comments Download
M user/src/com/google/gwt/dom/client/DOMImplIE9.java View 1 3 chunks +70 lines, -11 lines 4 comments Download
M user/src/com/google/gwt/dom/client/DOMImplStandard.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M user/src/com/google/gwt/dom/client/DOMImplStandardBase.java View 1 1 chunk +1 line, -1 line 0 comments Download
M user/src/com/google/gwt/dom/client/Document.java View 1 1 chunk +1 line, -1 line 0 comments Download
M user/test/com/google/gwt/user/client/EventTest.java View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7
fabiomfv
6 years, 1 month ago #1
jlabanca
http://gwt-code-reviews.appspot.com/1383809/diff/1/user/src/com/google/gwt/user/client/ui/CheckBox.java File user/src/com/google/gwt/user/client/ui/CheckBox.java (right): http://gwt-code-reviews.appspot.com/1383809/diff/1/user/src/com/google/gwt/user/client/ui/CheckBox.java#newcode88 user/src/com/google/gwt/user/client/ui/CheckBox.java:88: setFormValue("on"); Why not put this in DOMImplStandard as well?
6 years, 1 month ago #2
fabiomfv
6 years ago #3
jlabanca
LGTM As long as you put a more description comment in the IE9 tabIndex impl ...
6 years ago #4
mariusdumitru.florea
Document#getScrollTop() and Document#getScrollLeft() are broken for nested documents in IE9 (e.g. for a rich text ...
4 years, 1 month ago #5
tbroyer
Marius: I agree with your comments, but this change has actually been merged already (despite ...
4 years, 1 month ago #6
mariusdumitru.florea
4 years, 1 month ago #7
On 2013/03/18 12:03:46, tbroyer wrote:
> Marius: I agree with your comments, but this change has actually been merged
> already (despite not being closed here).
> 
> Please file an issue and possibly provide a patch (preferably to Gerrit rather
> than Rietveld)
> 
> As for the reasons of the method overrides, it probably has to do with this:
>
http://stackoverflow.com/questions/2717252/document-body-scrolltop-is-always-...
> (though I haven't tested in IE9 how it actually behaves; keeping in mind that
> the DOMImplIE9 is only used for "IE9 in IE9 Standards mode", i.e. documentMode
> >= 9)

See https://gwt-review.googlesource.com/#/c/2260/ .
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld revision f51cb906c4ad+