Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(56)

Issue 1430801: Use locale-insensitive checks in RF unit tests so they don't fail in non-English locales. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 11 months ago by tbroyer
Modified:
3 years, 8 months ago
Reviewers:
jat, rdayal
CC:
google-web-toolkit-contributors_googlegroups.com
Base URL:
Visibility:
Public.

Description

Use locale-insensitive checks in RF unit tests so they don't fail in non-English
locales.

Patch Set 1

Patch Set 2 : Rewrites RF unittests to be locale-insensitive instead of forcing en-US locale

Patch Set 3 : Removed leftover System.out for testing.

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java View 1 2 4 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 7
tbroyer
5 years, 11 months ago #1
rjrjr
LGTM Thanks, will submit. On Tue, May 3, 2011 at 2:40 AM, <t.broyer@gmail.com> wrote: > ...
5 years, 11 months ago #2
rjrjr
Running ant clean dist-dev test, this appears to break the i18n suite under html unit. ...
5 years, 11 months ago #3
tbroyer
On 2011/05/03 17:51:18, rjrjr wrote: > Running ant clean dist-dev test, this appears to break ...
5 years, 11 months ago #4
rjrjr
This is probably html unit honoring the locale and changing its behavior from what the ...
5 years, 11 months ago #5
jat
On Thu, May 5, 2011 at 3:58 AM, Thomas Broyer <t.broyer@gmail.com> wrote: > What I ...
5 years, 10 months ago #6
tbroyer
3 years, 8 months ago #7
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld revision f51cb906c4ad+