Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(198)

Issue 1525806: Updates MobileWebApp to use GWT Maven Plugin 2.3.0-1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by rchandia
Modified:
1 year, 9 months ago
Reviewers:
rjrjr, drfibonacci
CC:
google-web-toolkit-contributors_googlegroups.com
Base URL:
http://google-web-toolkit.googlecode.com/svn/
Visibility:
Public.

Description

Updates MobileWebApp to use GWT Maven Plugin 2.3.0-1
- It now honors scope "provided"
- Its is not necessary to clean up gwt-dev.jar nor gwt-user.jar

Patch Set 1

Total comments: 2

Patch Set 2 : Untabified pom.xml

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M samples/mobilewebapp/pom.xml View 1 7 chunks +10 lines, -49 lines 0 comments Download

Messages

Total messages: 8
rchandia
1 year, 9 months ago #1
rjrjr
http://gwt-code-reviews.appspot.com/1525806/diff/1/samples/mobilewebapp/pom.xml File samples/mobilewebapp/pom.xml (right): http://gwt-code-reviews.appspot.com/1525806/diff/1/samples/mobilewebapp/pom.xml#newcode191 samples/mobilewebapp/pom.xml:191: <version>2.3.0-1</version> What's the -1 for? Also, tab character in ...
1 year, 9 months ago #2
rchandia
1 year, 9 months ago #3
rchandia
http://gwt-code-reviews.appspot.com/1525806/diff/1/samples/mobilewebapp/pom.xml File samples/mobilewebapp/pom.xml (right): http://gwt-code-reviews.appspot.com/1525806/diff/1/samples/mobilewebapp/pom.xml#newcode191 samples/mobilewebapp/pom.xml:191: <version>2.3.0-1</version> On 2011/08/18 15:34:16, rjrjr wrote: > What's the ...
1 year, 9 months ago #4
rjrjr
Since when? I haven't seen the -1 before. On 2011/08/18 15:53:28, rchandia wrote: > http://gwt-code-reviews.appspot.com/1525806/diff/1/samples/mobilewebapp/pom.xml ...
1 year, 9 months ago #5
rchandia
According to the GWT maven plugin web page 2.3.0-1 is the latest version. http://mojo.codehaus.org/gwt-maven-plugin/ El ...
1 year, 9 months ago #6
rjrjr
LGTM D'oh! I thought that was meant to be *our* version string. Sorry. On Thu ...
1 year, 9 months ago #7
rchandia
1 year, 9 months ago #8
Submitted as r10549
On 2011/08/18 16:07:27, rjrjr wrote:
> LGTM
> 
> D'oh! I thought that was meant to be *our* version string. Sorry.
> 
> On Thu Aug 18 08:55:54 GMT-700 2011, Rodrigo Chandia wrote:
> 
> > According to the GWT maven plugin web page 2.3.0-1 is the latest version.
> >
> >
>
http://mojo.codehaus.org/gwt-maven-plugin/%3Chttp://www.google.com/url?sa=D&q...>
> >
> > El 18 de agosto de 2011 11:53,
>
<rchandia@google.com<http://www.google.com/url?sa=D&q=mailto%3Archandia%40google.com>
> > > escribió:
> >
> >
> > http://gwt-code-reviews.**appspot.com/1525806/diff/1/**
> >
>
samples/mobilewebapp/pom.xml<http://www.google.com/url?sa=D&q=http%3A%2F%2Fgwt-code-reviews.appspot.com%2F1525806%2Fdiff%2F1%2Fsamples%2Fmobilewebapp%2Fpom.xml>
> > File samples/mobilewebapp/pom.xml (right):
> >
> > http://gwt-code-reviews.**appspot.com/1525806/diff/1/**
> >
>
samples/mobilewebapp/pom.xml#**newcode191<http://www.google.com/url?sa=D&q=http%3A%2F%2Fgwt-code-reviews.appspot.com%2F1525806%2Fdiff%2F1%2Fsamples%2Fmobilewebapp%2Fpom.xml%23newcode191>
> > samples/mobilewebapp/pom.xml:**191: <version>2.3.0-1</version>
> > On 2011/08/18 15:34:16, rjrjr wrote:
> >
> > What's the -1 for? Also, tab character in this line.
> >
> > Done, untabified the file. The "-1" is part of the version string
> > "2.3.0-1"
> >
> >
> >
>
http://gwt-code-reviews.**appspot.com/1525806/%3Chttp://www.google.com/url?sa...>
> >
> >
> >
> >
> > --
> > Rodrigo Chandia | Software Engineer |
>
rchandia@google.com<http://www.google.com/url?sa=D&q=mailto%3Archandia%40google.com>
> >  | 678 7431725
> >
> >
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld revision f51cb906c4ad+