Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(950)

Issue 1542804: Less Name Mangling

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 5 months ago by stephenh
Modified:
3 years, 9 months ago
CC:
google-web-toolkit-contributors_googlegroups.com
Base URL:
Visibility:
Public.

Patch Set 1

Total comments: 1

Patch Set 2 : Fix todo, comments, misc

Patch Set 3 : Fix Foo.Bar.Zaz inner classes

Total comments: 21
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M dev/core/src/com/google/gwt/core/ext/typeinfo/JClassType.java View 1 chunk +3 lines, -0 lines 0 comments Download
M dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java View 2 chunks +19 lines, -1 line 2 comments Download
M dev/core/src/com/google/gwt/dev/asm/Type.java View 1 chunk +1 line, -1 line 0 comments Download
M dev/core/src/com/google/gwt/dev/javac/CompilationState.java View 4 chunks +9 lines, -3 lines 2 comments Download
M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java View 1 2 8 chunks +23 lines, -12 lines 2 comments Download
M dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java View 1 chunk +3 lines, -0 lines 1 comment Download
M dev/core/src/com/google/gwt/dev/javac/CompilationUnitInvalidator.java View 2 chunks +2 lines, -2 lines 0 comments Download
M dev/core/src/com/google/gwt/dev/javac/CompiledClass.java View 6 chunks +15 lines, -8 lines 2 comments Download
M dev/core/src/com/google/gwt/dev/javac/Dependencies.java View 1 3 chunks +6 lines, -2 lines 0 comments Download
M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java View 1 10 chunks +63 lines, -20 lines 5 comments Download
M dev/core/src/com/google/gwt/dev/javac/JsniChecker.java View 1 1 chunk +1 line, -1 line 1 comment Download
M dev/core/src/com/google/gwt/dev/javac/Resolver.java View 1 chunk +1 line, -1 line 0 comments Download
M dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java View 1 2 15 chunks +42 lines, -34 lines 1 comment Download
M dev/core/src/com/google/gwt/dev/javac/asm/CollectClassData.java View 1 2 4 chunks +24 lines, -2 lines 0 comments Download
M dev/core/src/com/google/gwt/dev/javac/asm/ResolveMethodSignature.java View 4 chunks +5 lines, -5 lines 0 comments Download
M dev/core/src/com/google/gwt/dev/javac/asm/ResolveTypeSignature.java View 4 chunks +7 lines, -7 lines 1 comment Download
M dev/core/src/com/google/gwt/dev/javac/typemodel/JRealClassType.java View 1 chunk +2 lines, -2 lines 1 comment Download
M dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java View 6 chunks +32 lines, -2 lines 0 comments Download
M dev/core/src/com/google/gwt/dev/jjs/AstConstructor.java View 1 chunk +1 line, -1 line 0 comments Download
M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java View 1 chunk +1 line, -1 line 0 comments Download
M dev/core/src/com/google/gwt/dev/jjs/ast/JGwtCreate.java View 2 chunks +2 lines, -2 lines 1 comment Download
M dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java View 7 chunks +26 lines, -14 lines 1 comment Download
M dev/core/src/com/google/gwt/dev/jjs/ast/JReferenceType.java View 1 chunk +3 lines, -0 lines 0 comments Download
M dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java View 5 chunks +7 lines, -10 lines 0 comments Download
M dev/core/src/com/google/gwt/dev/util/JsniRef.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M dev/core/src/com/google/gwt/dev/util/Name.java View 4 chunks +0 lines, -160 lines 0 comments Download
M dev/core/src/com/google/gwt/dev/util/TypeInfo.java View 1 chunk +1 line, -1 line 0 comments Download
M dev/core/test/com/google/gwt/dev/javac/CompiledClassTest.java View 1 chunk +1 line, -1 line 0 comments Download
M dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M dev/core/test/com/google/gwt/dev/javac/asm/ResolveGenericsTest.java View 3 chunks +5 lines, -5 lines 0 comments Download
M dev/core/test/com/google/gwt/dev/jjs/JjsTypeTest.java View 1 chunk +1 line, -1 line 0 comments Download
M dev/core/test/com/google/gwt/dev/jjs/impl/AdditionalTypeProviderDelegateTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M dev/core/test/com/google/gwt/dev/util/NameTest.java View 4 chunks +4 lines, -59 lines 0 comments Download
M user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java View 1 chunk +1 line, -1 line 0 comments Download
M user/src/com/google/web/bindery/requestfactory/server/RequestFactoryJarExtractor.java View 2 chunks +1 line, -2 lines 1 comment Download

Messages

Total messages: 12
stephenh
5 years, 5 months ago #1
stephenh
http://gwt-code-reviews.appspot.com/1542804/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java (right): http://gwt-code-reviews.appspot.com/1542804/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java#newcode109 dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java:109: unresolvedQualified.add(interner.intern(CharOperation.toString(qualifiedRef).replace('.', '/'))); Oh, right...I'll ask about this on the ...
5 years, 5 months ago #2
stephenh
I found some issues with JSNI and am still poking around, so this is not ...
5 years, 5 months ago #3
stephenh
5 years, 5 months ago #4
stephenh
5 years, 5 months ago #5
stephenh
Okay, this is ready for review.
5 years, 5 months ago #6
stephenh
Oh jeez. Reitveld just dropped a huge comment I had due to an invalid XSRF ...
5 years, 5 months ago #7
stephenh
http://gwt-code-reviews.appspot.com/1542804/diff/5001/dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java File dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java (right): http://gwt-code-reviews.appspot.com/1542804/diff/5001/dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java#newcode149 dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java:149: public abstract JClassType findTypeByInternalName(String name); TypeOracle clients (DevMode) had ...
5 years, 5 months ago #8
Lex Spoon
For what it's worth, this patch does not seem necessary for the Scala+GWT project. It ...
5 years, 4 months ago #9
rdayal
On 2011/10/09 13:58:44, Lex Spoon wrote: > For what it's worth, this patch does not ...
4 years, 9 months ago #10
stephenh
> Stephen, at a high level, what is this patch for? Basically fixing how GWT ...
4 years, 9 months ago #11
r.spilker
3 years, 9 months ago #12
One of the problems of the original code was that it was not possible to use the
dollar sign as part of an identifier in Java. Some code generators, like
http://projectlombok.org use the dollar sign in their generated code, and
therefore cannot effectively be used in a GWT project.

On 2012/05/03 20:57:22, stephenh wrote:
> > Stephen, at a high level, what is this patch for?
> 
> Basically fixing how GWT handles classes with "$" in them. Right now there are
a
> lot of places where GWT assumes "$" can be replaced by "." to go from, say, a
> binary class name of "Foo$Inner" to a source name of "Foo.Inner".
> 
> This is generally true for Java, but is not the case for Scala, so this patch
> was originally beneficial/required for Scala-GWT.
> 
> However, that is no longer the case, as broken binary <-> source name
conversion
> does not affect the current Scala-GWT approach.
> 
> So, AFAIK, now the only things this patch affects are basic aesthetics (e.g. I
> think it's cleaner to avoid the s/$/./ hacks) and gwt-query since they could
> then use "$" as a class name to do more jquery-style things (...IIRC, there is
a
> bug in the issue tracker about it).
> 
> > How important is it for GWT 2.5?
> 
> Not important.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld revision f51cb906c4ad+