Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(282)

Issue 1594804: Fix for issue 5926 (at last!) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 5 months ago by tbroyer
Modified:
3 years, 9 months ago
Reviewers:
rdayal, NotBobV
CC:
google-web-toolkit-contributors_googlegroups.com
Base URL:
Visibility:
Public.

Description

Fix for issue 5926 (at last!)

This CL fixes a couple things:
 - overrides with co-variant return type, as reported initially in issue 5926
 - support for generics in proxies, which can lead to the above (e.g. if you
override a method to set a @PropertyName on it), but also has its own set of
issues (type variables in getter's return type –used as the property type– have
to be "resolved" against the actual interface parameterization)

Patch Set 1

Patch Set 2 : Previous patch was missing an import (last-second change FTL)

Patch Set 3 : Fix @PropertyName handling on overridden methods.

Patch Set 4 : Fixed and enhanced tests.

Patch Set 5 : Added test for override with co-variant return type.

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
requestfactory/build.xml View 1 chunk +1 line, -0 lines 0 comments Download
M user/src/com/google/web/bindery/autobean/vm/impl/BeanPropertyContext.java View 2 chunks +5 lines, -4 lines 0 comments Download
M user/src/com/google/web/bindery/autobean/vm/impl/GetterPropertyContext.java View 2 chunks +6 lines, -16 lines 0 comments Download
M user/src/com/google/web/bindery/autobean/vm/impl/MethodPropertyContext.java View 1 chunk +18 lines, -48 lines 0 comments Download
M user/src/com/google/web/bindery/autobean/vm/impl/ProxyAutoBean.java View 1 2 9 chunks +165 lines, -48 lines 0 comments Download
M user/src/com/google/web/bindery/requestfactory/apt/ProxyScanner.java View 1 2 chunks +25 lines, -3 lines 0 comments Download
M user/src/com/google/web/bindery/requestfactory/apt/RequestContextScanner.java View 4 chunks +20 lines, -14 lines 0 comments Download
M user/src/com/google/web/bindery/requestfactory/apt/RequestFactoryScanner.java View 4 chunks +8 lines, -1 line 0 comments Download
M user/src/com/google/web/bindery/requestfactory/apt/ScannerBase.java View 2 chunks +16 lines, -3 lines 0 comments Download
M user/test/com/google/web/bindery/requestfactory/gwt/RequestFactorySuite.java View 2 chunks +2 lines, -0 lines 0 comments Download
A user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryGenericsTest.java View 1 2 3 4 1 chunk +236 lines, -0 lines 0 comments Download
A user/test/com/google/web/bindery/requestfactory/server/RequestFactoryGenericsJreTest.java View 1 chunk +16 lines, -0 lines 0 comments Download
M user/test/com/google/web/bindery/requestfactory/vm/RequestFactoryJreSuite.java View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2
tbroyer
OK, I think I nailed it. I still have some issues with RF, but they're ...
5 years, 5 months ago #1
tbroyer
3 years, 9 months ago #2
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld revision f51cb906c4ad+