user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTestBase.java - Issue 1601806: Fix for issue 5952: RequestContext#isChanged.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Unified Diff: user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTestBase.java

Issue 1601806: Fix for issue 5952: RequestContext#isChanged. (Closed)

Patch Set: Refactor fix + fix finishTestAndReset in test-harness Created 1 year ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java ('k') | user/test/com/google/web/bindery/requestfactory/server/RequestPayloadJreTest.java » ('j') | user/test/com/google/web/bindery/requestfactory/server/RequestPayloadJreTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTestBase.java

diff --git a/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTestBase.java b/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTestBase.java

index 340c7d4d9d194b8a66e9b1343a489e4b2cfcb1ff..2b35b8a85ed3b77388dd85630e43702aa30844bc 100644

--- a/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTestBase.java

+++ b/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTestBase.java

@@ -167,8 +167,9 @@ public abstract class RequestFactoryTestBase extends GWTTestCase {

protected void finishTestAndReset() {

SimpleFooRequest ctx = req.simpleFooRequest();

- ctx.reset();

+ // XXX: be careful to reset SimpleBar before SimpleFoo (as SimpleFoo needs SimpleBar)

ctx.append(req.simpleBarRequest()).reset();

+ ctx.reset();

ctx.fire(new Receiver<Void>() {

@Override

public void onSuccess(Void response) {