Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

Issue 1632803: Avoid Java bottleneck by using explicit Charset for byte[] <-> String conversions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 3 months ago by rdayal
Modified:
9 months, 3 weeks ago
Reviewers:
Jason Terk, tbroyer, skybrian, tbroyer
CC:
google-web-toolkit-contributors_googlegroups.com
Base URL:
http://google-web-toolkit.googlecode.com/svn/
Visibility:
Public.

Description

Avoid Java bottleneck by using explicit Charset for byte[] <-> String
conversions.

Repost of Rietveld issue 158803.
Patch By: Jason Terk

Patch Set 1

Patch Set 2 : No difference, screwed up the first submission

Patch Set 3 : ConcurrentHashMap cannot accept null. Changed calls to readContent to continue passing "UTF-8", ...

Patch Set 4 : Can't map null values in a map; passing null into readContent changes behavior.

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M user/src/com/google/gwt/user/server/rpc/HybridServiceServlet.java View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M user/src/com/google/gwt/user/server/rpc/RPCServletUtils.java View 1 2 3 19 chunks +75 lines, -26 lines 0 comments Download
M user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java View 1 2 3 23 chunks +33 lines, -35 lines 0 comments Download
M user/test/com/google/gwt/user/server/rpc/RPCServletUtilsTest.java View 1 2 3 5 chunks +30 lines, -5 lines 0 comments Download

Messages

Total messages: 9
rdayal
1 year, 3 months ago #1
rdayal
1 year, 3 months ago #2
rdayal
On 2012/01/30 22:31:09, rdayal wrote:
1 year, 3 months ago #3
tbroyer
LGTM
1 year, 3 months ago #4
rdayal
1 year, 3 months ago #5
rdayal
1 year, 1 month ago #6
rdayal
On 2012/04/05 18:59:13, rdayal wrote: Jason, can you look at this one more time? Sorry ...
1 year, 1 month ago #7
Jason Terk
LGTM
1 year, 1 month ago #8
rdayal
1 year, 1 month ago #9
On 2012/04/05 19:27:55, Jason Terk wrote:
> LGTM

Thanks, submitted.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld revision f51cb906c4ad+