Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(235)

Issue 1760804: Add a new constructor to CellTree to specify defaultNodeSize.

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by ximao
Modified:
2 months, 4 weeks ago
CC:
google-web-toolkit-contributors_googlegroups.com
Base URL:
http://google-web-toolkit.googlecode.com/svn/
Visibility:
Public.

Description

Add a new constructor to CellTree to specify defaultNodeSize.

CellTree opens the root node in constructor, so setDefaultNodeSize() has no
effect on the root node.
The first level in the CellTree always uses 25 as defaultNodeSize.

Sometimes we don't want the "show more" link to appear (that link doesn't hide
when the whole list have been shown),
setDefaultNodeSize() with a big number will hide the "show more" link, but it
can't remove the link under root node.

Patch Set 1

Patch Set 2 : sync and merged the latest code.

Patch Set 3 : update reviewer

Total comments: 2

Patch Set 4 : change per code review

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M user/src/com/google/gwt/user/cellview/client/CellTree.java View 1 2 3 3 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 8
ximao
4 years, 9 months ago #1
ximao
4 years, 9 months ago #2
ximao
4 years, 9 months ago #3
skybrian
LGTM http://gwt-code-reviews.appspot.com/1760804/diff/6001/user/src/com/google/gwt/user/cellview/client/CellTree.java File user/src/com/google/gwt/user/cellview/client/CellTree.java (right): http://gwt-code-reviews.appspot.com/1760804/diff/6001/user/src/com/google/gwt/user/cellview/client/CellTree.java#newcode807 user/src/com/google/gwt/user/cellview/client/CellTree.java:807: * tree nodes that are already open. Update: ...
4 years, 9 months ago #4
ximao
4 years, 9 months ago #5
ximao
http://gwt-code-reviews.appspot.com/1760804/diff/6001/user/src/com/google/gwt/user/cellview/client/CellTree.java File user/src/com/google/gwt/user/cellview/client/CellTree.java (right): http://gwt-code-reviews.appspot.com/1760804/diff/6001/user/src/com/google/gwt/user/cellview/client/CellTree.java#newcode807 user/src/com/google/gwt/user/cellview/client/CellTree.java:807: * tree nodes that are already open. On 2012/07/20 ...
4 years, 9 months ago #6
perrymasterson
> On 2012/07/20 20:54:01, skybrian wrote: > > Update: "other tree nodes that are already ...
6 months, 2 weeks ago #7
jamesmathu669188
2 months, 4 weeks ago #8
We are really grateful for your blog post.
best streaming http://mobdroapkdownload.com get free.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld revision f51cb906c4ad+