Add instrumentation for collecting client-side code coverage.

Add instrumentation for collecting client-side code coverage.

[cromwellian]

Sorry I've been at I/O all week, I will take a look at this as soon as I
can.



On Thu, Jun 28, 2012 at 5:30 PM, <isbadawi@google.com> wrote:

>
http://gwt-code-reviews.**appspot.com/1764803/<http://gwt-code-reviews.appspo...>
>

[skybrian]

LGTM

http://gwt-code-reviews.appspot.com/1764803/diff/6003/dev/core/src/com/google...
File dev/core/src/com/google/gwt/dev/js/BaselineCoverageGatherer.java (right):

http://gwt-code-reviews.appspot.com/1764803/diff/6003/dev/core/src/com/google...
dev/core/src/com/google/gwt/dev/js/BaselineCoverageGatherer.java:46: if
(System.getProperty("gwt.coverage") == null) {
Maybe this if statement should be at the call site in JavaToJavaScriptCompiler?
It would make it easier to see that nothing happens when the property isn't set.
Similarly for CoverageInstrumentor.

[isbadawi]

On 2012/07/14 00:31:23, skybrian wrote:
> LGTM
> 
>
http://gwt-code-reviews.appspot.com/1764803/diff/6003/dev/core/src/com/google...
> File dev/core/src/com/google/gwt/dev/js/BaselineCoverageGatherer.java (right):
> 
>
http://gwt-code-reviews.appspot.com/1764803/diff/6003/dev/core/src/com/google...
> dev/core/src/com/google/gwt/dev/js/BaselineCoverageGatherer.java:46: if
> (System.getProperty("gwt.coverage") == null) {
> Maybe this if statement should be at the call site in
JavaToJavaScriptCompiler?
> It would make it easier to see that nothing happens when the property isn't
set.
> Similarly for CoverageInstrumentor.

I just went this way because this is how JsStackEmulator does it. If there's no
real reason (style/convention or otherwise) to do it that way then I agree.