Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(274)

Issue 1815803: Ensures integer pixel values and adds getters for subpixel values

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 8 months ago by John A.
Modified:
3 years, 11 months ago
CC:
google-web-toolkit-contributors_googlegroups.com
Base URL:
http://google-web-toolkit.googlecode.com/svn/trunk/user/
Visibility:
Public.

Patch Set 1

Total comments: 5

Patch Set 2 : Fixed issues mentioned in review

Patch Set 3 : Removed non related changes to JavaDoc

Patch Set 4 : Added omitted subpixel rounding in DOMImpl and DOMImplIE9

Messages

Total messages: 7
tbroyer
Are there tests that could be added / updated? http://gwt-code-reviews.appspot.com/1815803/diff/1/src/com/google/gwt/dom/client/DOMImpl.java File src/com/google/gwt/dom/client/DOMImpl.java (right): http://gwt-code-reviews.appspot.com/1815803/diff/1/src/com/google/gwt/dom/client/DOMImpl.java#newcode149 src/com/google/gwt/dom/client/DOMImpl.java:149: ...
4 years, 8 months ago #1
John A.
http://gwt-code-reviews.appspot.com/1815803/diff/1/src/com/google/gwt/dom/client/DOMImplStandard.java File src/com/google/gwt/dom/client/DOMImplStandard.java (right): http://gwt-code-reviews.appspot.com/1815803/diff/1/src/com/google/gwt/dom/client/DOMImplStandard.java#newcode61 src/com/google/gwt/dom/client/DOMImplStandard.java:61: screenY|0, clientX|0, clientY|0, ctrlKey, altKey, shiftKey, metaKey, button, You ...
4 years, 8 months ago #2
John A.
Fixed the issues mentioned by Thomas. Daniel, did you have any comments on this? http://gwt-code-reviews.appspot.com/1815803/diff/1/src/com/google/gwt/dom/client/DOMImpl.java ...
4 years ago #3
goktug
3 years, 12 months ago #4
skybrian
Hello, could you avoid reformatting code that you're not working on? Or if you want ...
3 years, 11 months ago #5
John A.
On 2013/04/30 23:05:08, skybrian wrote: > Hello, could you avoid reformatting code that you're not ...
3 years, 11 months ago #6
skybrian
3 years, 11 months ago #7
On 2013/05/06 08:05:00, John A. wrote:
> On 2013/04/30 23:05:08, skybrian wrote:
> > Hello, could you avoid reformatting code that you're not working on? Or if
you
> > want to just fix the javadoc, do that in a separate CL.
> 
> Appears the eclipse auto formatting had changed Element JavaDocs without me
> noticing, Removed the changes, sorry about that.

Thanks!

(I think this change makes sense, but hard to say without testing.)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld revision f51cb906c4ad+