Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(959)

Issue 1832803: ValueListBox should implement HasEnabled (6112)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by Patrick Tucker
Modified:
3 years, 8 months ago
Reviewers:
mdempsky, jtamplin, tbroyer
CC:
google-web-toolkit-contributors_googlegroups.com
Base URL:
http://google-web-toolkit.googlecode.com/svn/trunk/
Visibility:
Public.

Description

ValueListBox should implement HasEnabled, functionality can easily be delegated
to the internal ListBox.

http://code.google.com/p/google-web-toolkit/issues/detail?id=6112

Patch Set 1

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
user/src/com/google/gwt/user/client/ui/ValueListBox.java View 3 chunks +11 lines, -1 line 0 comments Download
user/test/com/google/gwt/user/client/ui/ValueListBoxTest.java View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8
Patrick Tucker
4 years, 5 months ago #1
Patrick Tucker
On 2012/09/16 02:36:41, Patrick Tucker wrote: Anybody?
3 years, 9 months ago #2
mdempsky
Thanks for the patch! But do you mind reuploading it to https://gwt-review.googlesource.com/gwt so we can ...
3 years, 9 months ago #3
mdempsky
On 2013/05/16 19:35:21, mdempsky wrote: > Thanks for the patch! But do you mind reuploading ...
3 years, 9 months ago #4
jtamplin
On Fri, May 17, 2013 at 6:11 AM, Patrick Tucker <tuckerpmt@gmail.com> wrote: > I would ...
3 years, 9 months ago #5
mdempsky
On Fri, May 17, 2013 at 9:45 AM, Patrick Tucker <tuckerpmt@gmail.com> wrote: > I'm not ...
3 years, 9 months ago #6
Patrick Tucker
From the gwtproject "Making GWT Better" page section "Gerrit Setup" step 3: > Make a ...
3 years, 8 months ago #7
tbroyer
3 years, 8 months ago #8
On Mon, Jun 10, 2013 at 3:35 PM, Patrick Tucker <tuckerpmt@gmail.com> wrote:
> From the gwtproject "Making GWT Better" page section "Gerrit Setup" step 3:
>>
>> Make a change and commit it locally using git (e.g., edit a file foo and
>> then run ?git commit -m ?my first change? foo?).
>
>
> What does foo represent?

The file(s) you want to commit (automatically does a "git add")
http://git-scm.com/docs/git-commit


--
Thomas Broyer
/tɔ.ma.bʁwa.je/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld revision f51cb906c4ad+