Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(66)

Issue 1851803: Set visibility:hidden on the ruler element in LayoutImpl

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by flooey1
Modified:
3 years, 12 months ago
CC:
google-web-toolkit-contributors_googlegroups.com
Base URL:
http://google-web-toolkit.googlecode.com/svn/
Visibility:
Public.

Description

Set visibility:hidden on the ruler element in LayoutImpl
to prevent it from capturing click events when it
overlaps elements above it.

Patch Set 1

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M user/src/com/google/gwt/layout/client/LayoutImpl.java View 2 chunks +2 lines, -0 lines 4 comments Download

Messages

Total messages: 7
flooey1
4 years, 5 months ago #1
mdempsky
http://gwt-code-reviews.appspot.com/1851803/diff/1/user/src/com/google/gwt/layout/client/LayoutImpl.java File user/src/com/google/gwt/layout/client/LayoutImpl.java (right): http://gwt-code-reviews.appspot.com/1851803/diff/1/user/src/com/google/gwt/layout/client/LayoutImpl.java#newcode60 user/src/com/google/gwt/layout/client/LayoutImpl.java:60: style.setTop(-20, heightUnit); We should be able to eliminate this ...
4 years, 5 months ago #2
mdempsky
LGTM Brian, what do you think? http://gwt-code-reviews.appspot.com/1851803/diff/1/user/src/com/google/gwt/layout/client/LayoutImpl.java File user/src/com/google/gwt/layout/client/LayoutImpl.java (right): http://gwt-code-reviews.appspot.com/1851803/diff/1/user/src/com/google/gwt/layout/client/LayoutImpl.java#newcode69 user/src/com/google/gwt/layout/client/LayoutImpl.java:69: State.HIDDEN.set(ruler, true); Looks ...
4 years, 5 months ago #3
flooey1
http://gwt-code-reviews.appspot.com/1851803/diff/1/user/src/com/google/gwt/layout/client/LayoutImpl.java File user/src/com/google/gwt/layout/client/LayoutImpl.java (right): http://gwt-code-reviews.appspot.com/1851803/diff/1/user/src/com/google/gwt/layout/client/LayoutImpl.java#newcode60 user/src/com/google/gwt/layout/client/LayoutImpl.java:60: style.setTop(-20, heightUnit); On 2012/10/04 23:08:51, mdempsky wrote: > We ...
4 years, 5 months ago #4
skybrian
LGTM I don't quite understand why it's capturing click events when it's 10x10 and it's ...
4 years, 5 months ago #5
bruno.ferreira
On 2012/10/05 18:01:35, skybrian wrote: > LGTM > > I don't quite understand why it's ...
3 years, 12 months ago #6
mdempsky
3 years, 12 months ago #7
On 2013/04/01 14:36:56, bruno.ferreira wrote:
> Is this problem solved on GWT 2.5.1?

I believe so.  This patch was merged and included in GWT 2.5.1.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld revision f51cb906c4ad+