Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Enter>
:
respond to / edit current comment
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(51)
Issues
Repositories
Search
Open Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
1867803
: Fix GeneratedClassnameFinder for OpenJDK 7 javac.
Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 2 weeks ago by
mdempsky
Modified:
6 months, 2 weeks ago
Reviewers:
skybrian
CC:
google-web-toolkit-contributors_googlegroups.com
Base URL:
http://google-web-toolkit.googlecode.com/svn/
Visibility:
Public.
Description
Fix GeneratedClassnameFinder for OpenJDK 7 javac.
Patch Set 1
Created:
6 months, 2 weeks ago
Download raw patch set
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
Patch
M
dev/core/src/com/google/gwt/dev/javac/CompilationUnit.java
View
4 chunks
+38 lines, -2 lines
0 comments
Download
M
dev/core/test/com/google/gwt/dev/javac/GeneratedClassnameFinderTest.java
View
2 chunks
+25 lines, -0 lines
0 comments
Download
Messages
Total messages: 2
Expand All Messages
|
Collapse All Messages
mdempsky
6 months, 2 weeks ago
#1
Sign in
to reply to this message.
skybrian
LGTM. Not really familiar with this code, though.
6 months, 2 weeks ago
#2
LGTM. Not really familiar with this code, though.
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 1867803: Fix GeneratedClassnameFinder for OpenJDK 7 javac.
Created 6 months, 2 weeks ago by mdempsky
Modified 6 months, 2 weeks ago
Reviewers: skybrian
Base URL: http://google-web-toolkit.googlecode.com/svn/
Comments: 0
Recent Issues
|
This issue
This is Rietveld
revision f51cb906c4ad+