Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(849)

Issue 1868803: Move non-GWTTestCase tests in RpcSuite to RpcSuiteNoBrowser,

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 8 months ago by skybrian
Modified:
1 year, 8 months ago
Reviewers:
mdempsky
CC:
google-web-toolkit-contributors_googlegroups.com
Base URL:
http://google-web-toolkit.googlecode.com/svn/
Visibility:
Public.

Description

Move non-GWTTestCase tests in RpcSuite to RpcSuiteNoBrowser,
so they don't unnecessarily get run multiple times in different browser
environments.
Also fix the build to handle running *SuiteNoBrowser suites.

Review by: mdempsky@google.com

Patch Set 1

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M user/build.xml View 1 chunk +1 line, -1 line 0 comments Download
M user/test/com/google/gwt/user/RPCSuite.java View 3 chunks +1 line, -34 lines 0 comments Download
A user/test/com/google/gwt/user/RpcSuiteNoBrowser.java View 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 3
skybrian
1 year, 8 months ago #1
mdempsky
LGTM
1 year, 8 months ago #2
skybrian
1 year, 8 months ago #3
On Fri, Nov 16, 2012 at 12:20 AM, Thomas Broyer <t.broyer@gmail.com> wrote:
> Should we rename the *JreSuite in e.g. RequestFactory to *SuiteNoBrowser
> too? I kind of like this naming scheme, easier to deal with than *Suite vs.
> *JreSuite.

Good point, I hadn't seen those. Yes I like my name better :-)

- Brian
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld revision f51cb906c4ad+