Issue 1868803: Move non-GWTTestCase tests in RpcSuite to RpcSuiteNoBrowser,

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 1868803: Move non-GWTTestCase tests in RpcSuite to RpcSuiteNoBrowser,

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 months, 1 week ago by skybrian

Modified:
6 months, 1 week ago

Reviewers:
mdempsky

CC:
google-web-toolkit-contributors_googlegroups.com

Base URL:
http://google-web-toolkit.googlecode.com/svn/

Visibility:
Public.

Description

Move non-GWTTestCase tests in RpcSuite to RpcSuiteNoBrowser,
so they don't unnecessarily get run multiple times in different browser
environments.
Also fix the build to handle running *SuiteNoBrowser suites.

Review by: mdempsky@google.com

Patch Set 1

Created: 6 months, 1 week ago

Download raw patch set

	Unified diffs	Side-by-side diffs	Stats			Patch
M	user/build.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	user/test/com/google/gwt/user/RPCSuite.java	View	3 chunks	+1 line, -34 lines	0 comments	Download
A	user/test/com/google/gwt/user/RpcSuiteNoBrowser.java	View	1 chunk	+64 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

skybrian

6 months, 1 week ago #3

On Fri, Nov 16, 2012 at 12:20 AM, Thomas Broyer <t.broyer@gmail.com> wrote:
> Should we rename the *JreSuite in e.g. RequestFactory to *SuiteNoBrowser
> too? I kind of like this naming scheme, easier to deal with than *Suite vs.
> *JreSuite.

Good point, I hadn't seen those. Yes I like my name better :-)

- Brian

Expand All Messages | Collapse All Messages