Issue 1869803: Minor cleanup in SerializableTypeOracleBuilder:

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 1869803: Minor cleanup in SerializableTypeOracleBuilder:

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 months ago by skybrian

Modified:
6 months ago

Reviewers:
mdempsky, jtamplin

CC:
google-web-toolkit-contributors_googlegroups.com

Base URL:
http://google-web-toolkit.googlecode.com/svn/

Visibility:
Public.

Description

Minor cleanup in SerializableTypeOracleBuilder:
- remove unused fields
- TypeInfoComputed can be static
- tighten visibility
- remove some indirection
- fix some warnings

Review by: mdempsky@google.com

Patch Set 1

Patch Set 2 : update to use ensureTypeInfoComputed or direct access

Created: 6 months ago

Download raw patch set

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java	View	1	21 chunks	+22 lines, -57 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

LGTM too.

Expand All Messages | Collapse All Messages