Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(45)

Issue 1869803: Minor cleanup in SerializableTypeOracleBuilder:

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by skybrian
Modified:
2 years, 1 month ago
Reviewers:
mdempsky, jtamplin
CC:
google-web-toolkit-contributors_googlegroups.com
Base URL:
http://google-web-toolkit.googlecode.com/svn/
Visibility:
Public.

Description

Minor cleanup in SerializableTypeOracleBuilder:
- remove unused fields
- TypeInfoComputed can be static
- tighten visibility
- remove some indirection
- fix some warnings

Review by: mdempsky@google.com

Patch Set 1

Patch Set 2 : update to use ensureTypeInfoComputed or direct access

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java View 1 21 chunks +22 lines, -57 lines 0 comments Download

Messages

Total messages: 4
skybrian
2 years, 1 month ago #1
skybrian
2 years, 1 month ago #2
jtamplin
LGTM
2 years, 1 month ago #3
mdempsky
2 years, 1 month ago #4
LGTM too.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld revision f51cb906c4ad+