Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(112)

Issue 1869804: Fix a bug where GWT-RPC would not generate some covariant array types, possibly causing inconsis...

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 8 months ago by skybrian
Modified:
1 year, 8 months ago
CC:
google-web-toolkit-contributors_googlegroups.com
Base URL:
http://google-web-toolkit.googlecode.com/svn/
Visibility:
Public.

Description

Fix a bug where GWT-RPC would not generate some covariant array types, possibly
causing inconsistent serialization policies. Includes a test.

Fixes issue 7791

Patch Set 1

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java View 9 chunks +115 lines, -64 lines 0 comments Download
M user/test/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilderTest.java View 3 chunks +77 lines, -0 lines 2 comments Download
A user/test/com/google/gwt/user/rebind/rpc/testcases/client/SubclassUsedInArray.java View 1 chunk +48 lines, -0 lines 2 comments Download

Messages

Total messages: 4
skybrian
1 year, 8 months ago #1
stephenh
http://gwt-code-reviews.appspot.com/1869804/diff/1/user/test/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilderTest.java File user/test/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilderTest.java (right): http://gwt-code-reviews.appspot.com/1869804/diff/1/user/test/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilderTest.java#newcode2435 user/test/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilderTest.java:2435: private <T> String join(String delimiter, T... items) { Why ...
1 year, 8 months ago #2
skybrian
http://gwt-code-reviews.appspot.com/1869804/diff/1/user/test/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilderTest.java File user/test/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilderTest.java (right): http://gwt-code-reviews.appspot.com/1869804/diff/1/user/test/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilderTest.java#newcode2435 user/test/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilderTest.java:2435: private <T> String join(String delimiter, T... items) { On ...
1 year, 8 months ago #3
cromwellian
1 year, 8 months ago #4
Usually in other part of the compiler, that is called 'ComponentType'
or 'ElementType'


On Wed, Nov 21, 2012 at 11:28 AM,  <skybrian@google.com> wrote:
>
>
http://gwt-code-reviews.appspot.com/1869804/diff/1/user/test/com/google/gwt/u...
> File
>
user/test/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilderTest.java
> (right):
>
>
http://gwt-code-reviews.appspot.com/1869804/diff/1/user/test/com/google/gwt/u...
>
user/test/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilderTest.java:2435:
> private <T> String join(String delimiter, T... items) {
> On 2012/11/21 15:39:58, stephenh wrote:
>>
>> Why not reuse an existing join, like Guava's joiner?
>
> No good reason, just in a hurry.
>
>
>
http://gwt-code-reviews.appspot.com/1869804/diff/1/user/test/com/google/gwt/u...
> File
>
user/test/com/google/gwt/user/rebind/rpc/testcases/client/SubclassUsedInArray.java
> (right):
>
>
http://gwt-code-reviews.appspot.com/1869804/diff/1/user/test/com/google/gwt/u...
>
user/test/com/google/gwt/user/rebind/rpc/testcases/client/SubclassUsedInArray.java:30:
> /** Array's leaf type. Not a root so its subtypes aren't cached. */
> On 2012/11/21 15:39:58, stephenh wrote:
>>
>> Why does the comment here say "Array's leaf type", but the next class
>
> is "class
>>
>> LeafType"?
>
>
> Sorry about that! "Leaf" is used two different ways and I somehow didn't
> notice. One is the type hierarchy: Base->Subtype->LeafType. But also, in
> the array code, for a type such as Foo[][], we're calling "Foo" the leaf
> type.
>
> We should probably decide on some consistent terminology and stick with
> it.
>
>
> http://gwt-code-reviews.appspot.com/1869804/
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld revision f51cb906c4ad+