Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(237)

Issue 1893803: Make PopupPanel#setAnimationType public

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 2 months ago by patou.de.saint.steban
Modified:
6 months, 2 weeks ago
Reviewers:
tbroyer, jesscraunfield
CC:
google-web-toolkit-contributors_googlegroups.com
Base URL:
http://google-web-toolkit.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Change the visibility of the method setAnimationType to public for allow to
change the animation type of a popup panel and use other animation type like
expend from the top left corner or roll down.

Patch Set 1

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
user/src/com/google/gwt/user/client/ui/PopupPanel.java View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4
patou.de.saint.steban
4 years, 2 months ago #1
tbroyer
4 years, 2 months ago #2
tbroyer
If you still care about it, could you please move the patch over to Gerrit? ...
3 years, 10 months ago #3
jesscraunfield
6 months, 2 weeks ago #4
On 2013/02/21 16:41:18, patou.de.saint.steban wrote:

Change the visibility of method is not the same as allowing users make changes
in the popup panel. With that complicated task http://pimion.com can cope
easily.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld revision f51cb906c4ad+