Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(68)

Issue 1894803: Issue # 3520: More Flexible Date Picker

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by Wiggyclone
Modified:
4 years ago
CC:
Base URL:
http://google-web-toolkit.googlecode.com/svn/trunk/
Visibility:
Public.

Description

There are a couple of fixes. The first fix added the functionality for a more
flexible date picker. The second fixes a problem with the month-shifting math in
CalendarUtil.java which made month navigation prior to the year 1900 erroneous.

Patch Set 1

Total comments: 6

Patch Set 2 : Here is the new patch

Total comments: 14

Messages

Total messages: 20
Wiggyclone
4 years, 1 month ago #1
Patrick Tucker
On 2013/02/25 18:38:18, Wiggyclone wrote: Shouldn't this capability be added to a new class so ...
4 years, 1 month ago #2
Wiggyclone
On 2013/02/26 22:13:58, Patrick Tucker wrote: > On 2013/02/25 18:38:18, Wiggyclone wrote: > > Shouldn't ...
4 years ago #3
mdempsky
Thanks for the patch! I've added some comments. http://gwt-code-reviews.appspot.com/1894803/diff/1/user/src/com/google/gwt/user/datepicker/client/CalendarModel.java File user/src/com/google/gwt/user/datepicker/client/CalendarModel.java (right): http://gwt-code-reviews.appspot.com/1894803/diff/1/user/src/com/google/gwt/user/datepicker/client/CalendarModel.java#newcode77 user/src/com/google/gwt/user/datepicker/client/CalendarModel.java:77: public ...
4 years ago #4
willseph
On 2013/03/15 19:23:07, mdempsky wrote: > Thanks for the patch! I've added some comments. > ...
4 years ago #5
mdempsky
On Fri, Mar 15, 2013 at 2:30 PM, <cswillseph@gmail.com> wrote: > We determined that those ...
4 years ago #6
willseph
On 2013/03/15 21:50:08, mdempsky wrote: > On Fri, Mar 15, 2013 at 2:30 PM, <mailto:cswillseph@gmail.com> ...
4 years ago #7
mdempsky
On Fri, Mar 15, 2013 at 2:30 PM, <cswillseph@gmail.com> wrote: > We may also need ...
4 years ago #8
mdempsky
On Fri, Mar 15, 2013 at 2:58 PM, <cswillseph@gmail.com> wrote: > So I assume you ...
4 years ago #9
willseph
On 2013/03/15 22:06:28, mdempsky wrote: > On Fri, Mar 15, 2013 at 2:58 PM, <mailto:cswillseph@gmail.com> ...
4 years ago #10
Wiggyclone
On 2013/03/15 22:07:31, willseph wrote: > On 2013/03/15 22:06:28, mdempsky wrote: > > On Fri, ...
4 years ago #11
Wiggyclone
Here is the new patch
4 years ago #12
willseph
On 2013/03/16 17:19:14, Wiggyclone wrote: > Here is the new patch Any updates on this?
4 years ago #13
mdempsky
Thanks, looking better. A few more comments. http://gwt-code-reviews.appspot.com/1894803/diff/13001/user/src/com/google/gwt/user/datepicker/client/CalendarModel.java File user/src/com/google/gwt/user/datepicker/client/CalendarModel.java (right): http://gwt-code-reviews.appspot.com/1894803/diff/13001/user/src/com/google/gwt/user/datepicker/client/CalendarModel.java#newcode82 user/src/com/google/gwt/user/datepicker/client/CalendarModel.java:82: * Formats ...
4 years ago #14
skybrian
Larger issue: there are 20+ subclasses of DatePicker in our code (and certainly more outside ...
4 years ago #15
mdempsky
> But if your goal is just to get any change checked in, an easy ...
4 years ago #16
willseph
On 2013/03/18 19:37:05, mdempsky wrote: > > But if your goal is just to get ...
4 years ago #17
willseph
Do you need us to submit a standalone patch for the CalendarUtil.java fix?
4 years ago #18
skybrian
On 2013/03/19 06:01:32, willseph wrote: > Do you need us to submit a standalone patch ...
4 years ago #19
willseph
4 years ago #20
On 2013/03/19 16:26:37, skybrian wrote:
> On 2013/03/19 06:01:32, willseph wrote:
> > Do you need us to submit a standalone patch for the CalendarUtil.java fix?
> 
> Yes, let's do that.

Okay perfect, I added a separate issue for this specific patch here:
http://gwt-code-reviews.appspot.com/1898803/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld revision f51cb906c4ad+