Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(67)

Issue 1897803: Issue 7890 : ListBox: allow CSS class for options

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by wadael
Modified:
4 years ago
Reviewers:
tbroyer, Patrick Tucker
CC:
google-web-toolkit-contributors_googlegroups.com
Base URL:
http://google-web-toolkit.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Hello,
Here is my patch for ListBox.

Adds several methods like 'addStyledItem' in order to add class name to option.

Browsers do not support all styles on option elements (for example italic) but
color and background are the common denominator of the three main pc browsers.

AFAIU, I had to add 'styled' to avoid the API compatibility check errors due to
signature collisions.

https://code.google.com/p/google-web-toolkit/issues/detail?id=7890

Patch Set 1

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
user/src/com/google/gwt/user/client/ui/ListBox.java View 3 chunks +45 lines, -2 lines 2 comments Download
user/test/com/google/gwt/user/client/ui/ListBoxTest.java View 1 chunk +13 lines, -0 lines 1 comment Download

Messages

Total messages: 3
wadael
4 years ago #1
tbroyer
I'm still not convinced that this is an issue worth fixing (we don't allow adding ...
4 years ago #2
Patrick Tucker
4 years ago #3
On 2013/03/19 15:40:06, tbroyer wrote:

I agree, returning the OptionElement seems like a better idea.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld revision f51cb906c4ad+