Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 1899803: Issue 5525 - Allow EntityProxyId as an argument to a Request Factory service method

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by salk31
Modified:
3 years, 10 months ago
Reviewers:
tbroyer, sam
CC:
Base URL:
http://google-web-toolkit.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This seems to work already, apart from the validator rejecting it.

The patch just allows EntityProxyId as a valid transport type.

It works for my use case but this is the first time I've looked at this code so
sorry if I've missed lots of other nasty cases.

https://code.google.com/p/google-web-toolkit/issues/detail?id=5525

Patch Set 1

Patch Set 2 : Try 3 - cargo cult and sloppy

Total comments: 1

Patch Set 3 : with findSimpleFooById as suggested by tbroyer

Messages

Total messages: 12
salk31
3 years, 11 months ago #1
tbroyer
Could you please add some unit-tests?
3 years, 11 months ago #2
salk31
Try 2 - cargo cult attempt at unit tests
3 years, 11 months ago #3
salk31
On 2013/04/14 08:30:06, salk31 wrote: > Try 2 - cargo cult attempt at unit tests ...
3 years, 11 months ago #4
salk31
Try 3 - cargo cult and sloppy
3 years, 11 months ago #5
tbroyer
Sounds good! http://gwt-code-reviews.appspot.com/1899803/diff/5005/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java File user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java (right): http://gwt-code-reviews.appspot.com/1899803/diff/5005/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java#newcode1493 user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java:1493: req.simpleFooRequest().fetchDoubleReference().fire( Use findSimpleFoo(1L) instead.
3 years, 11 months ago #6
salk31
with findSimpleFooById as suggested by tbroyer
3 years, 11 months ago #7
salk31
Do I have to do anything to keep this going? Ask for other reviewers? Press ...
3 years, 11 months ago #8
tbroyer
On 2013/04/20 07:05:08, salk31 wrote: > Do I have to do anything to keep this ...
3 years, 10 months ago #9
sam
I don't mind having a go. Got it all set up so I can do ...
3 years, 10 months ago #10
sam
I'll have a go if that is OK. Already set things up with this in ...
3 years, 10 months ago #11
salk31
3 years, 10 months ago #12
https://gwt-review.googlesource.com/3091

Sorry about previous double reply, senior moment.

I hope this is OK. I'm keen to try and contribute more. GWT has made my day job
seem professional. Looking forward to the move to Maven.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld revision f51cb906c4ad+