Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(276)

Issue 1900803: Fixing AbsolutePanel to set positioning of 'right' instead of 'left' for RTL languages. Without ...

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by yaminik
Modified:
4 years ago
CC:
google-web-toolkit-contributors_googlegroups.com
Base URL:
http://google-web-toolkit.googlecode.com/svn/
Visibility:
Public.

Description

Fixing AbsolutePanel to set positioning of 'right' instead of 'left' for RTL
languages. Without this, statements such as RootPanel.get().add(widget, 0, 0) or
add(widget, -100, -100) causes horizontal scroll bar on window.

Review by: goktug@google.com

Patch Set 1

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M user/src/com/google/gwt/user/client/ui/AbsolutePanel.java View 4 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 7
yaminik
4 years ago #1
goktug
On 2013/04/17 05:14:32, yaminik wrote: Reviewers needed. I don't have much experience with RTL issues. ...
4 years ago #2
jtamplin
On 2013/04/17 17:21:49, goktug wrote: > On 2013/04/17 05:14:32, yaminik wrote: > > Reviewers needed. ...
4 years ago #3
yaminik
On 2013/04/17 17:36:30, jtamplin wrote: > On 2013/04/17 17:21:49, goktug wrote: > > On 2013/04/17 ...
4 years ago #4
Andrew Bachmann
DockLayoutPanel separates line_start from west, and it seems like it would be appropriate to separate ...
4 years ago #5
goktug
Thanks Andrew & John! Yes, agreed. Having RTL-aware methods makes sense: setWidgetPosition => sets left ...
4 years ago #6
aharon
4 years ago #7
Sorry, but my contributions to GWT bidi are limited to text directionality
issues (the ability to display correctly text values whose direction is opposite
that of the UI). I do not know much about the way GWT handles layout
directionality (flipping the horizontal layout in RTL UIs), so I can't respond
very intelligently to the proposed change.

You might want to get the input of Adil Allawi <adil@diwan.com> and Shanjian Li
<shanjian@google.com>, who (as far as I understand) did most of the layout bidi
in GWT. 

Nevertheless, I do agree that simply changing the meaning of the "left"
parameter is bound to break existing applications. So, the proposed set of
setWidget...Position methods sounds reasonable, although I would consider using
just Start and End instead of LineStart and LineEnd, since "start" and "end" are
fairly well accepted in this sense (e.g. text-align:start and text-align:end in
CSS). More importantly, I would want to make sure that this fits with the way
the existing layout bidi is done in GWT, and for that you need the input of
someone else, perhaps Adil or Shanjian.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld revision f51cb906c4ad+