Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(69)

Issue 1902803: corrects typos

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by stalcup
Modified:
3 years, 11 months ago
CC:
google-web-toolkit-contributors_googlegroups.com
Base URL:
http://google-web-toolkit.googlecode.com/svn/
Visibility:
Public.

Description

corrects typos

Patch Set 1

Messages

Total messages: 8
stalcup
3 years, 11 months ago #1
rluble
LGTM. I can not believe that this was not caught by anyone before.
3 years, 11 months ago #2
mdempsky
Face palm. Does this break backwards compatibility at all? E.g., are any of the permuation ...
3 years, 11 months ago #3
mdempsky
On 2013/04/17 23:12:34, mdempsky wrote: > Face palm. (And that's at the typos being overlooked ...
3 years, 11 months ago #4
rluble
Ray, are these public methods used at all by custom linkers or any other user ...
3 years, 11 months ago #5
stalcup
i did some google.com searches for these and looked at the results manually. google.com can't ...
3 years, 11 months ago #6
stalcup
Ray what do you think of the safety of these changes? On Thu, Apr 18, ...
3 years, 11 months ago #7
skybrian
3 years, 11 months ago #8
I did a Google search for getPermuationId and didn't find any hits other than
our own code.

In theory anything in core/ext/linker is a public linker API, but I think this
is pretty safe. Not many people write their own linkers.

Since it is an API change, we should remember it when writing GWT 2.6 release
notes. The way we remember is by creating an external bug with Milestone=2_6,
refer to it in the CL description, and make sure it's set to FixedNotReleased
after submitting the change. (It will automatically be closed as "Fixed" after
mirroring to SVN and we set it back again manually.)

On 2013/04/19 19:34:40, stalcup wrote:
> Ray what do you think of the safety of these changes?
> 
> 
> On Thu, Apr 18, 2013 at 10:42 AM, John Stalcup <mailto:stalcup@google.com>
wrote:
> 
> > i did some http://google.com searches for these and looked at the results
> > manually. http://google.com can't any non-GWT core uses of them.
> >
> >
>
generateCompilerMetricsForOnePermuation<https://www.google.com/search?q=generateCompilerMetricsForOnePermuation&aq=f&oq=generateCompilerMetricsForOnePermuation&aqs=chrome.0.57j60l2j62.217j0&sourceid=chrome&ie=UTF-8#hl=en&sclient=psy-ab&q=gwt+generateCompilerMetricsForOnePermuation+-google-web-toolkit-contributors+-%22google-web-toolkit+commit%22+-gwt-contrib+-site:gwt.googlesource.com+-site%3Agoogle-web-toolkit.googlecode.com+-GoogleWebToolkitContributors+-%22Copyright+2010+Google+Inc.%22++-%22Copyright+2007+Google+Inc.%22++-%22Copyright+2008+Google+Inc.%22++-%22Copyright+2009+Google+Inc.%22++-%22Copyright+2011+Google+Inc.%22&oq=gwt+generateCompilerMetricsForOnePermuation+-google-web-toolkit-contributors+-%22google-web-toolkit+commit%22+-gwt-contrib+-site:gwt.googlesource.com+-site%3Agoogle-web-toolkit.googlecode.com+-GoogleWebToolkitContributors+-%22Copyright+2010+Google+Inc.%22++-%22Copyright+2007+Google+Inc.%22++-%22Copyright+2008+Google+Inc.%22++-%22Copyright+2009+Google+Inc.%22++-%22Copyright+2011+Google+Inc.%22&gs_l=serp.3...50631.50631.15.51021.1.1.0.0.0.0.0.0..0.0.les%3B..0.1.0..1c.1.2.psy-ab.kKMznJbghHs&pbx=1&bav=on.2,or.r_cp.r_qf.&bvm=bv.45373924,d.cGE&fp=22c0045b81c4e652&biw=2560&bih=1480>
> >
>
getPermuationBase<https://www.google.com/search?q=generateCompilerMetricsForOnePermuation&aq=f&oq=generateCompilerMetricsForOnePermuation&aqs=chrome.0.57j60l2j62.217j0&sourceid=chrome&ie=UTF-8#hl=en&sclient=psy-ab&q=gwt+getPermuationBase+-google-web-toolkit-contributors+-%22google-web-toolkit+commit%22+-gwt-contrib+-site:gwt.googlesource.com+-site%3Agoogle-web-toolkit.googlecode.com+-GoogleWebToolkitContributors+-%22Copyright+2010+Google+Inc.%22++-%22Copyright+2007+Google+Inc.%22++-%22Copyright+2008+Google+Inc.%22++-%22Copyright+2009+Google+Inc.%22++-%22Copyright+2011+Google+Inc.%22&oq=gwt+getPermuationBase+-google-web-toolkit-contributors+-%22google-web-toolkit+commit%22+-gwt-contrib+-site:gwt.googlesource.com+-site%3Agoogle-web-toolkit.googlecode.com+-GoogleWebToolkitContributors+-%22Copyright+2010+Google+Inc.%22++-%22Copyright+2007+Google+Inc.%22++-%22Copyright+2008+Google+Inc.%22++-%22Copyright+2009+Google+Inc.%22++-%22Copyright+2011+Google+Inc.%22&gs_l=serp.3...18029.18029.16.19771.1.1.0.0.0.0.0.0..0.0.les%3B..0.1.0..1c.1.2.psy-ab.gx3nfK3VVeI&pbx=1&bav=on.2,or.r_cp.r_qf.&bvm=bv.45373924,d.cGE&fp=22c0045b81c4e652&biw=2560&bih=1480>
> >
>
getPermuationId<https://www.google.com/search?q=generateCompilerMetricsForOnePermuation&aq=f&oq=generateCompilerMetricsForOnePermuation&aqs=chrome.0.57j60l2j62.217j0&sourceid=chrome&ie=UTF-8#hl=en&sclient=psy-ab&q=gwt+getPermuationId+-google-web-toolkit-contributors+-%22google-web-toolkit+commit%22+-gwt-contrib+-site:gwt.googlesource.com+-site%3Agoogle-web-toolkit.googlecode.com+-GoogleWebToolkitContributors+-%22Copyright+2010+Google+Inc.%22++-%22Copyright+2007+Google+Inc.%22++-%22Copyright+2008+Google+Inc.%22++-%22Copyright+2009+Google+Inc.%22++-%22Copyright+2011+Google+Inc.%22&oq=gwt+getPermuationId+-google-web-toolkit-contributors+-%22google-web-toolkit+commit%22+-gwt-contrib+-site:gwt.googlesource.com+-site%3Agoogle-web-toolkit.googlecode.com+-GoogleWebToolkitContributors+-%22Copyright+2010+Google+Inc.%22++-%22Copyright+2007+Google+Inc.%22++-%22Copyright+2008+Google+Inc.%22++-%22Copyright+2009+Google+Inc.%22++-%22Copyright+2011+Google+Inc.%22&gs_l=serp.3...13955.13955.17.14289.1.1.0.0.0.0.0.0..0.0.les%3B..0.1.0..1c.1.2.psy-ab.nal9zLlTMXQ&pbx=1&bav=on.2,or.r_cp.r_qf.&bvm=bv.45373924,d.cGE&fp=22c0045b81c4e652&biw=2560&bih=1480>
> >
>
getPermuationCount<https://www.google.com/search?q=generateCompilerMetricsForOnePermuation&aq=f&oq=generateCompilerMetricsForOnePermuation&aqs=chrome.0.57j60l2j62.217j0&sourceid=chrome&ie=UTF-8#hl=en&sclient=psy-ab&q=gwt+getPermuationCount+-google-web-toolkit-contributors+-%22google-web-toolkit+commit%22+-gwt-contrib+-site:gwt.googlesource.com+-site%3Agoogle-web-toolkit.googlecode.com+-GoogleWebToolkitContributors+-%22Copyright+2010+Google+Inc.%22++-%22Copyright+2007+Google+Inc.%22++-%22Copyright+2008+Google+Inc.%22++-%22Copyright+2009+Google+Inc.%22++-%22Copyright+2011+Google+Inc.%22&oq=gwt+getPermuationCount+-google-web-toolkit-contributors+-%22google-web-toolkit+commit%22+-gwt-contrib+-site:gwt.googlesource.com+-site%3Agoogle-web-toolkit.googlecode.com+-GoogleWebToolkitContributors+-%22Copyright+2010+Google+Inc.%22++-%22Copyright+2007+Google+Inc.%22++-%22Copyright+2008+Google+Inc.%22++-%22Copyright+2009+Google+Inc.%22++-%22Copyright+2011+Google+Inc.%22&gs_l=serp.3...11310.11310.18.11677.1.1.0.0.0.0.0.0..0.0.les%3B..0.1.0..1c.1.2.psy-ab.Jg40wXflJ1Q&pbx=1&bav=on.2,or.r_cp.r_qf.&bvm=bv.45373924,d.cGE&fp=22c0045b81c4e652&biw=2560&bih=1480>
> >
> >
> >
> >
> > On Wed, Apr 17, 2013 at 4:49 PM, <mailto:rluble@google.com> wrote:
> >
> >> Ray, are these public methods used at all by custom linkers or any other
> >> user code?
> >>
> >>
>
http://gwt-code-reviews.**appspot.com/1902803/%3Chttp://gwt-code-reviews.apps...>
> >>
> >
> >
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld revision f51cb906c4ad+