Simplifies the RequestObject api:

Simplifies the RequestObject api:
* No more clearUsed(). Requests are always usable
* No more reset(), it was basically unused, and untested
* RequestData move to an impl package

Also fixes violation reporting in AbstractProxyEditActivity,
and simplifies its last remaining echo of future ids

[amitmanjhi]

The patch is missing a test that we discussed -- the test posts a sequence of
edits and verifies that sane results are returned.

http://gwt-code-reviews.appspot.com/880801/diff/3001/4001
File user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java (left):

http://gwt-code-reviews.appspot.com/880801/diff/3001/4001#oldcode149
user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java:149: }
Why was this conditional removed?

http://gwt-code-reviews.appspot.com/880801/diff/3001/4001#oldcode156
user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java:156:
toCommit.fire(receiver);
where is the fire call now?

[rjrjr]

Fair enough re: the test.

http://gwt-code-reviews.appspot.com/880801/diff/3001/4001
File user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java (left):

http://gwt-code-reviews.appspot.com/880801/diff/3001/4001#oldcode149
user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java:149: }
Because we can receive no errors that are not related to our request, and
because stableId is only set for creates.

On 2010/09/15 08:15:53, amitmanjhi wrote:
> Why was this conditional removed?

http://gwt-code-reviews.appspot.com/880801/diff/3001/4001#oldcode156
user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java:156:
toCommit.fire(receiver);
On 2010/09/15 08:15:53, amitmanjhi wrote:
> where is the fire call now?

Line 114. The receiver variable was inlined, it served no purpose.

[rjrjr]

Test added, submitted r8799

On 2010/09/15 17:25:21, rjrjr wrote:
> Fair enough re: the test.
> 
> http://gwt-code-reviews.appspot.com/880801/diff/3001/4001
> File user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java (left):
> 
> http://gwt-code-reviews.appspot.com/880801/diff/3001/4001#oldcode149
> user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java:149: }
> Because we can receive no errors that are not related to our request, and
> because stableId is only set for creates.
> 
> On 2010/09/15 08:15:53, amitmanjhi wrote:
> > Why was this conditional removed?
> 
> http://gwt-code-reviews.appspot.com/880801/diff/3001/4001#oldcode156
> user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java:156:
> toCommit.fire(receiver);
> On 2010/09/15 08:15:53, amitmanjhi wrote:
> > where is the fire call now?
> 
> Line 114. The receiver variable was inlined, it served no purpose.